Skip to content

Fix double grad hang bug #34023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix double grad hang bug #34023

merged 1 commit into from
Jul 9, 2021

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jul 8, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

Avoid to transverse duplicate GradOpNodes when pruning the backward graph.

Fix #33989 .

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 8, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@sneaxiy sneaxiy requested a review from wzzju July 8, 2021 03:34
wzzju
wzzju approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@wzzju wzzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 8768ffb into PaddlePaddle:develop Jul 9, 2021
@sneaxiy sneaxiy deleted the fix_double_grad_cpu_hang_bug branch July 9, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wzzju wzzju wzzju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

paddle.grad for large models is very slow

2 participants

@sneaxiy @wzzju